Fix: Cursors over UI elements should indicate clickable or text entry

[belcherj]

Fix

Cursors in the UI do not use the proper type to indicate when elements are clickable or editable. This PR fixes those issue across the app.

Test

1. Run the branch
2. Step through app hovering over anything that is clickable and verify that the cursor changes to "pointer"
3. Hover over anything that allows text entry and verify that the cursor changes to "text"

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

• Hovering over a clickable or editable UI element now show the correct cursor for its type

[dmsnell]

I'm not sure what to expect. Are there any before/after screenshots? I don't particularly know what "the proper type" means or how I would know that a cursor is the wrong type. Is there a way we could provide any more description in here?

[codebykat]

@dmsnell There were essentially no pointer cursors over any clickable elements. I'll 👀

[codebykat]

This is already a huge improvement! 👏 I noticed a few places that still need attention:

• The note list on the sidebar (to switch notes, or to pin/unpin a note -- should be pointer, is default)
• Tags at the bottom of a note, when it has tags (should be pointer, is text cursor)
• "Add a tag..." at the bottom of a note (should be text cursor, is default -- only in Firefox, it's correct in Safari)

[belcherj]

The note list on the sidebar (to switch notes, or to pin/unpin a note -- should be pointer, is default)

This should have resolved that https://github.com/Automattic/simplenote-electron/pull/1573/files#diff-b4aef3f86a137f3edaf5a4e2fbb2a23fR104 Do you not see the pointer

Tags at the bottom of a note, when it has tags (should be pointer, is text cursor)

"Add a tag..." at the bottom of a note (should be text cursor, is default -- only in Firefox, it's correct in Safari)

Made Tags that are on a note pointer since clicking on them removes from note. In the UI spring cleaning, this interaction will be cleaned up. Where you enter new tags I changed the cursor to text.

[codebykat]

I do not see the pointer over the notes sidebar, over the pin/unpin or over the note itself:

I tested this in both Firefox and Safari.

Verified that the other two are working now 👍

[codebykat]

Okay so for whatever reason it's not working to add it to .note-list-item in theme.scss (none of those styles seem to be loaded for me), but it works if added to .note-list-item in note-list/style.scss.

[codebykat]

Looks great now!