Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt at fixing white screen error #1563

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Sep 3, 2019

Fix

Attempts to fix issue where this function cannot be found causing a js failure. In the image below Ks is the function this PR moves.

image

Test

This failure is intermittent and cannot be replicated

Review

Only one developer ise required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes as we don't know if this will resolve the issue

@belcherj belcherj added this to the 1.10 milestone Sep 3, 2019
@belcherj belcherj requested a review from a team September 3, 2019 17:05
@belcherj belcherj self-assigned this Sep 3, 2019
Copy link

@cbauerman cbauerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the white-screen issue, or any other issues, so LGTM

@belcherj belcherj merged commit 0549faa into develop Sep 3, 2019
@dmsnell dmsnell deleted the fix/whitescreen-issue branch October 1, 2019 18:17
@dmsnell
Copy link
Member

dmsnell commented Oct 1, 2019

@belcherj did we get a report of this breaking? how were we made aware.

it appears to be an issue with the Babel process, whereby we formerly were allowed to move const declarations below their first use because Babel rewrote them as var statements, and the bindings were hoisted up above in scope.

@beaucollins has been doing some work to remove other related hoisting issues in #1596. These defects have always been in the code, but babel hid them during the code transformation.

Was it possible that this appeared when trying to run the app without the Babel transform?

@belcherj
Copy link
Contributor Author

belcherj commented Oct 1, 2019

That could have been the case. It was very intermittent and I never experienced the issue. We were made aware via support requests. @dmsnell

@dmsnell
Copy link
Member

dmsnell commented Oct 1, 2019

We were made aware via support requests.

This is interesting. It's worth keeping an eye on this and related issues, though I think that the work here and in #1596 probably took care of most of it.

@loremattei loremattei modified the milestones: 1.10, 1.9 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants