Fix/webpack chunkname with hash #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa31f36.
Reports of the wrong chunk being served with a particular build suggest that cached, stale chunks may be served. This results in a broken application. Add chunkhash to the chunkFilename to ensure that the expected chunks are requested and eliminate issues with cached chunks. See https://webpack.js.org/configuration/output/#outputchunkfilename
sirreal
added
tooling
|
This PR would require some changes to the backend. I will see about making those changes but this may have to wait till I'm back from AFK. Thank you so much for this. I had been meaning to make this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
chunkhashtochunkFilenameAlternative to #1516 (reverted here).
Reports of the wrong chunk being served with a particular build suggest
that cached, stale chunks may be served. This results in a broken
application.
Add chunkhash to the chunkFilename to ensure that the expected chunks
are requested and eliminate issues with cached chunks.
See
https://webpack.js.org/configuration/output/#outputchunkfilename
Please test and review carefully, I'm new to this codebase