Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor jumps to new note while editing from browser. #2085

Closed
rezzap opened this issue May 14, 2020 · 14 comments · Fixed by #2148
Closed

Cursor jumps to new note while editing from browser. #2085

rezzap opened this issue May 14, 2020 · 14 comments · Fixed by #2148
Labels
bug Something isn't working

Comments

@rezzap
Copy link

rezzap commented May 14, 2020

Expected

I would expect that when I'm typing in a note the cursor stays in place and doesn't jump to a new note.

Observed

Two user's have reported that their cursor jumps to a new note while typing and inserts text into the new note.

Reproduced

I have tried to replicate this on a Windows PC and on Mac, but I haven't been able to reproduce it so far. The steps the users' mention are:

  1. Go to app.simplenote.com in a Firefox browser (also reported for Chrome but waiting on more details) with all extensions disabled
  2. Click to create a new note
  3. See the cursor going back to the previous note and characters inserted there.

User reports and screenshots/videos available in tickets 2964499-zen and 2935713-zen.

This seems to happen more regularly when they type in Portuguese or Swedish. I've tried with both French and Swedish keyboards without any problems.

Make Model OS Version App Version
Windows PC Windows 10 Electron on Firefox 76.0.1
@rezzap rezzap added the bug Something isn't working label May 14, 2020
@msilbers
Copy link

reported in 2938942-zen

Simplenote on web (version 1.16.0-beta2)
ChromeOS (Pixelbook Go, beta channel)

@msilbers
Copy link

msilbers commented May 15, 2020

reported in 2957214-zen

Chromebook
Chrome OS 81, using Chrome browser (same version)

"This morning I was in a note I update each day. I was entering, in the body of the note, the time. I entered 7:30 and might have put the space in before going on but after the 7:30 the cursor jumped to the title in a totally different note I have not touched since mid April."

@msilbers
Copy link

msilbers commented May 15, 2020

reported in 2955741-zen

Chrome (81.0) iMac with OSX 10.11 (El Capitan)

"The issue appears when I create a new note; while writing on it suddenly the order of the notes change and find myself writing in an older note...
the glitch still persists during writing plain text (maybe accents because I write notes in Spanish and Catalan…)."

@azollafox
Copy link

Reported in #2964499-zen
User only sees on Firefox 76.0.1 . Does not see in Chrome

@rachelmcr
Copy link
Member

Thanks for these reports! This looks like a duplicate of #2084. cc @belcherj as we have a sudden influx of these reports and it's very disruptive.

@belcherj
Copy link
Contributor

This is my priority. TY!

@ker8
Copy link

ker8 commented May 20, 2020

Also happening in Chrome OS Version 81.0.4044.141

For a while now actually I think last few months but cannot tolerate it anymore as its getting in my work. And its unusably slow.

@gubrist
Copy link

gubrist commented May 25, 2020

Happening with me with Windows 10, Electron Version 1.16.0.
Jumping to the top of another, existing note.

Similar effect as former bug
https://github.com/Automattic/simplenote-electron/issues/461
which did jump within the actual note.

@azollafox
Copy link

Another report in Window version 1.16.0 and on Opera 68.0.3618.125
#3028630-zen

@azollafox
Copy link

Anther report:
Android app = Phone/Android 8.1 = Simplenote 2.5.1
Web app = Chromebook/Chrome OS 83 = Simplenote 1.16.0-2078

#30149270-zen . User is also reporting sync issues from Android app to the web

@ker8
Copy link

ker8 commented Jun 8, 2020

This problem is getting crazy to be honest and simplenote is no longer usable for months! Plus its gotten very slow lately. I feel sad to leave simplenote though but it left me no choice... I hope their dev team will sort it out soon but its been months now...

@azollafox
Copy link

Another report at #3029327-zen. Asking for details on what devices/versions of Simplenote they are using

@gubrist
Copy link

gubrist commented Jun 11, 2020

I assume a relation to this "jumping" problem:

#1531

@belcherj
Copy link
Contributor

This is resolved on the web. Adding to the 1.18.0 release today which will occur tomorrow. This will not be out on Windows until the certification issues are resolved.

dmsnell added a commit that referenced this issue Sep 21, 2020
co-authored by @belcherj and @codebykat with design work by @SylvesterWilmott 

## Description

We've been unable to resolve the worst sync bugs in the application and feature development has been artificially limited by the fact that we have to fight a number of data-flow issues tightly coupling different levels of the application's architecture together.

In this branch, we're ripping apart the entire app state and Simperium data flow to rebuild it in order to remove a number of those couplings and races. This commit changes most of the app and was rolled out in staging to test the changes.

We're also replacing `draft-js` with `Monaco` which is almost as big of a change conceptually as changing the state. Moving to `Monaco` allows us to remove a copy of the note data from the app and allows us to maintain a fully-synchronous update cycle, eliminating a race condition between the Simperium copy of the data, the app copy, and the contents in the text buffer.

## Major code changes

 - The interface between `node-simperium` and this app has been moved into Redux state and out of `indexedDB`. The `indexedDB` interface as asynchronous and led to sync issues under a variety of race conditions with the network data, remote updates, browser tab scheduling, whether the browser was focused or hidden behind other windows, and more. The new synchronous interface guarantees that updates occur when we expect them to occur and therefore will be updated by the time we continue processing changes and updates from the server.
 - `Monaco`'s synchronous plaintext interface allows us to extend the atomic "all updates occur together and instantaneously" paradigm to the text buffer. By sharing the note data in the text editor, in the app, and in `node-simperium`, we will guarantee that we won't accidentally apply new edits to old data.
 - In many cases we have been dispatching multiple actions in order to perform one real action. For example, edit a note and then clear out the search state. Because these presented intermediate states for the app, partial updates, they have been removed. Now we have created new Redux actions for these real actions and app state has been adjusted so that each kind of data has its own reducer and those reducers listen to all the actions which could affect them.  Now we will see a single dispatch that multiple reducers listen to instead of dispatching one action type for each reducer.
 - The Simperium connection has been moved into a new centralized middleware. All Simperium interactions take place in this middleware and are no longer woven into the app. This allows the app to update so that there's only ever one copy of a note's data and it's always up to date with the text editor. This resolves longstanding issues with the note list showing expired data. It also allows us to model the Simperium connection as a reactive system that responds to changes in the app and injects new events from the server in a way that's independent from local operation. This has dramatically simplified many different subsystems.
 - The persistence layer has now been created as a separate subsystem from before, when it was integrated with the Simperium code. It now operates as a kind of background worker that persists the Redux state into `indexedDB` and stores the entire contents atomically. Previously, integrated into the note bucket, the persistence layer would update each note, ghost, and bucket value separately leading to mismatches between a note and the base version it was built from, leading to sync issues.
 - So-called "prop drilling" has been replaced by connecting components in the React tree to state. This was done to simplify the interfaces around the app. It was previously difficult to understand what exactly was executing with the `onAction` props because there wasn't a clear way to walk up the component tree in an editor without resorting to text searching. Any `onEdit` type actions have been replaced with `dispatchProps` that directly dispatch the intended actions.

## Related or fixed issues

### Defects
Resolves #2171 (note display doesn't update height immediately upon change from menu bar)
Resolves #2074 (floating IME on Korean input)
Resolves #2014 (when opened note changes so it's not in the search, it still stays open)
Resolves #1953 (when renaming tag, update in search bar if tag opened)
Resolves #1942 (can't easily select start of note content)
Resolves #1887 (renaming a tag removes it from a note)

#### Cursor position and movement
Resolves #2085 (cursor jumps to new note)
Resolves #2035 (cursor hidden at bottom of note)
Resolves #1595 (restore cursor position when flipping between edit/preview mode)
Resolves #1477 (cursor jumping in Windows)

#### Synchronization
Resolves #1938 (not restoring tags when reverting to an earlier revision)
Resolves #1641 (updates to a tag in one session don't update in other sessions until they reload)
Resolves #1640 (infinite duplication of tag name when editing tag)
Resolves #1562 (content not syncing)
Resolves #1520 (only syncing one note at a time/per session)
Resolves #1291 (quirky unsynced changes info)
Resolves #502 (data loss when editing simultaneous with iOS)
Resolves #459 (show note sync indicator)

#### Force-sync
#1897
#800

#### Ghost-Writing
Resolves #2030
Resolves #1787

### Enhancements
Resolves #2162 (mostly - additional syncing metadata for notes)
Resolves #1836 (remove `app-state`)
Resolves #1816 (confusing revision history ordering)
#1537 (add indicator to show syncing status)
Resolves #2036 (logging-out in one sessions logs out all sessions)
Resolves #1410 (logout is buried in app settings and hard to find)

#### Private Mode
#1924 - functionality in Firefox private mode other than offline persistence

### Performance
Resolves #2172 (slow app)
Resolves #501 (slow loading large notes)

### Deprecations
Resolves #2117 (audit use of draftJS)
Resolves #1762 (decorator performance in draftJS)
Resolves #1026 (use of `token` in `localStorage` in `boot.js`)

### Possibly - check these
#1698 (problems with Korean input and lists at start of note)
#1619 (buggy Japanese IME conversion)
#1572 (RTL languages - checked tasks moving to the right)
#1511 (missing characters on Korean IME conversion)
#1456 (slow, possibly 4K-resolution-related)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants