Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate copy/cut no word #1843

Closed
Jairjua opened this issue Jan 17, 2020 · 1 comment · Fixed by #1847
Closed

eliminate copy/cut no word #1843

Jairjua opened this issue Jan 17, 2020 · 1 comment · Fixed by #1847
Labels
feature request Request for a new feature

Comments

@Jairjua
Copy link

Jairjua commented Jan 17, 2020

What

After I copy/cut some word, if I copy (ctrl+c) or cut no word (without select a word/letter), the old one is erased. I can't past the first one.

Why

Linux do not works this way. I lost some important informations because I thought simplenote had the same behaviour as Linux.

How

Please, make copy/cut no word do not erase the temporary copy/cut memory.

I use Linux mint 19.2, 8GB RAM, intel i5.

@Jairjua Jairjua added the feature request Request for a new feature label Jan 17, 2020
dmsnell added a commit that referenced this issue Jan 17, 2020
Resolves #1843

Previously it has been the case that if you attempt to copy something in
the note editor but there is no selection then it will wipe out the
system's copy buffer. This is because we implement our own copy handler
which strips away the visual formatting of elements in the note editor.

 1. Copy anything in any app, suppose you copy "test"
 2. Paste that "test" anywhere, it pastes
 3. Click in the note editor but don't select anything.
 4. "Copy" by hitting the copy shortcut or by using a menu option
 5. Paste anywhere

Although we'd expect that "test" is still in our copy buffer we get the
empty string pasted in and "test" is gone.

While not really _wrong_ or _broken_ this is a bit jarring and it's
probably better in most cases to preserve the previous copy buffer if
we're not copying anything. We've turned the copy command into a "clear
the copy buffer" command if there's no content.

In this patch we're aborting the copy if our selection is empty and that
will preserve the existing buffer and the expected behavior.
@dmsnell
Copy link
Member

dmsnell commented Jan 17, 2020

Thanks for the report @Jairjua - I hadn't noticed this myself until I tried to figure out exactly what was going on. Thankfully it appears like a simpler update to make this work the way you expect it.

dmsnell added a commit that referenced this issue Jan 21, 2020
Resolves #1843

Previously it has been the case that if you attempt to copy something in
the note editor but there is no selection then it will wipe out the
system's copy buffer. This is because we implement our own copy handler
which strips away the visual formatting of elements in the note editor.

 1. Copy anything in any app, suppose you copy "test"
 2. Paste that "test" anywhere, it pastes
 3. Click in the note editor but don't select anything.
 4. "Copy" by hitting the copy shortcut or by using a menu option
 5. Paste anywhere

Although we'd expect that "test" is still in our copy buffer we get the
empty string pasted in and "test" is gone.

While not really _wrong_ or _broken_ this is a bit jarring and it's
probably better in most cases to preserve the previous copy buffer if
we're not copying anything. We've turned the copy command into a "clear
the copy buffer" command if there's no content.

In this patch we're aborting the copy if our selection is empty and that
will preserve the existing buffer and the expected behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants