Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Sidebar button non-responsive until dev console is opened #1525

Closed
rachelmcr opened this issue Aug 15, 2019 · 2 comments · Fixed by #1819
Closed

Toggle Sidebar button non-responsive until dev console is opened #1525

rachelmcr opened this issue Aug 15, 2019 · 2 comments · Fixed by #1819
Assignees
@belcherj
Labels
bug Something isn't working

Comments

@rachelmcr
Copy link
Member

Expected

I expect that clicking the "Toggle Sidebar" button will expand/collapse the sidebar.

Observed

Clicking the "Toggle Sidebar" button did nothing.

When I opened the dev console, the button suddenly started working and continued working after I closed the console.

Reproduced

  1. Log in to the app if needed.
  2. Click the "Toggle Sidebar" button. Note that it is unresponsive.
  3. Open the dev console (under Help > Advanced > Debugging Console).
  4. Try again to toggle the sidebar.

Reproduced on both Windows 10 VM and macOS 10.14.5, with Simplenote 1.8-beta1
@rachelmcr rachelmcr added the bug Something isn't working label Aug 15, 2019
@codebykat
Copy link
Member

This has happened to me twice now and I can't figure out how to consistently reproduce it. In both cases it did not start working when I opened the dev console, but did start working after I resized the window to be narrow enough that the toggle went away, and then back to full width.

@codebykat
Copy link
Member

Three times and it seems to always happen when I first load up the dev environment in a browser, so some race condition with the cache possibly? Once I've loaded it in a browser logging out, reloading, and stopping and restarting the dev server fail to produce the bug again.

@belcherj belcherj self-assigned this Jan 7, 2020
@belcherj belcherj mentioned this issue Jan 7, 2020
Merged
belcherj added a commit that referenced this issue Jan 7, 2020
@belcherj
Fixes focus mode toggle (#1819)
2694d3e 
When the app loads there is potential for the is-note-open css class to be
missing on app-layout. This removes the reliance on isNoteOpen as it is note
needed and should be independent. Now focus mode class will remain on all
screen widths but will only change the layout for widths greater than 750px. We
should look at why is-note-open is not applied to app layout and how the layout
is set up in general. Fixed: #1525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belcherj belcherj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes focus mode toggle Automattic/simplenote-electron
3 participants
@codebykat @belcherj @rachelmcr