Various linting fixes (#2337)

This PR cleans up some lint warnings that have been introduced over time:

- Remove a console.log where it seemed unnecessary
- Changed a console.log to debug where it made sense to keep the logging
- Changed some variable names to distinguish from variables declared in an upper scope

desktop/app.js

@@ -123,8 +123,8 @@ module.exports = function main() {
       mainWindow.setMenuBarVisibility(!autoHideMenuBar);
     });
 
-    ipcMain.on('wpLogin', function (event, url) {
-      shell.openExternal(url);
+    ipcMain.on('wpLogin', function (event, wpLoginUrl) {
+      shell.openExternal(wpLoginUrl);
     });
 
     ipcMain.on('importNotes', function (event, filePath) {

lib/boot.ts

@@ -12,7 +12,7 @@ import { boot as bootLoggingOut } from './logging-out';
 const config = getConfig();
 
 const clearStorage = (): Promise<void> =>
-  new Promise((resolve) => {
+  new Promise((resolveStorage) => {
     localStorage.removeItem('access_token');
     localStorage.removeItem('lastSyncedTime');
     localStorage.removeItem('localQueue:note');
@@ -57,9 +57,9 @@ const clearStorage = (): Promise<void> =>
     ])
       .then(() => {
         window.electron?.send('clearCookies');
-        resolve();
+        resolveStorage();
       })
-      .catch(() => resolve());
+      .catch(() => resolveStorage());
   });
 
 const forceReload = () => history.go();

lib/note-editor/index.tsx

@@ -58,7 +58,6 @@ export class NoteEditor extends Component<Props> {
 
     // toggle Markdown enabled
     if (note && cmdOrCtrl && shiftKey && 'm' === key) {
-      console.log('toggling markdown');
       toggleMarkdown(noteId, !this.markdownEnabled());
       event.stopPropagation();
       event.preventDefault();

lib/state/electron/middleware.ts

@@ -1,7 +1,11 @@
+import debugFactory from 'debug';
+
 import actions from '../actions';
 
 import * as S from '../';
 
+const debug = debugFactory('electron-middleware');
+
 export const middleware: S.Middleware = ({ dispatch, getState }) => {
   window.electron.receive('appCommand', (command) => {
     switch (command.action) {
@@ -82,7 +86,7 @@ export const middleware: S.Middleware = ({ dispatch, getState }) => {
         return;
 
       default:
-        console.log(command);
+        debug(`unknown AppCommand: ${command}`);
     }
   });