Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for translating strings in JavaScript files in Importer #3319

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Add support for translating strings in JavaScript files in Importer #3319

merged 2 commits into from
Jun 23, 2020

Conversation

jom
Copy link
Member

@jom jom commented Jun 23, 2020

Changes proposed in this Pull Request

Testing instructions

@jom jom added this to the 3.3.0 milestone Jun 23, 2020
@jom jom requested a review from renatho June 23, 2020 20:58
@jom jom self-assigned this Jun 23, 2020
renatho
renatho reviewed Jun 23, 2020
View reviewed changes
bin/pot-dist-references.js Outdated Show resolved Hide resolved
renatho
renatho approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested generating the files and adding the translations for another language and it worked well!

@jom jom merged commit 51d2c0d into master Jun 23, 2020
@jom jom deleted the change/allow-importer-i18n branch June 23, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatho renatho renatho approved these changes

Assignees

@jom jom

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jom @renatho