-
Notifications
You must be signed in to change notification settings - Fork 0
feat: update patterns and remove unused files #3
Conversation
@thomasguillot thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
e1ce8eb
to
1e23a86
Compare
@thomasguillot I'll test this after #1 is merged |
@dkoo the PR should be up-to-date with the main branch. I hope it didn't break everything 🥺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasguillot on a fresh site, when activating the plugin I see this fatal in PHP log:
[02-Jul-2024 23:21:00 UTC] PHP Fatal error: Uncaught Error: Class "PublisherMediaKit\blocks\BlockContext\Tabs" not found in /newspack-repos/publisher-media-kit-for-newspack/publisher-media-kit.php:102
Stack trace:
#0 /var/www/html/wp-admin/includes/plugin.php(2389): include_once()
#1 /var/www/html/wp-admin/includes/plugin.php(675): plugin_sandbox_scrape()
#2 /var/www/html/wp-admin/plugins.php(60): activate_plugin()
#3 {main}
thrown in /newspack-repos/publisher-media-kit-for-newspack/publisher-media-kit.php on line 102
It doesn't seem to affect the content of page itself, though
@dkoo For some reason I can't replicate the error. I noticed in https://github.com/10up/publisher-media-kit/pull/125/files they removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing the error anymore on JN—I'm going to go ahead and approve.
This PR takes the various patterns to the next level. Making the most of the Editor instead of relying on custom CSS.
I've also removed a bunch of unused files.
Temp demo: https://speedily-given.wp.build/media-kit/
How to test
1- Install this plugin, activate it
2- Go to edit the new Media Kit page created (note: you will need to permanently delete any previously created)
3- Check if it works as expected (please use the block theme for now. if you use the classic theme, the colours will be missing)