Fix build error C2664 - cannot convert argument 6 from 'nullptr' to 'DWORD #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "error C2664: 'HANDLE CreateFileW(LPCWSTR,DWORD,DWORD,LPSECURITY_ATTRIBUTES,DWORD,DWORD,HANDLE)': cannot convert argument 6 from 'nullptr' to 'DWORD' [D:\a\node-canvas\node-canvas\build\canvas.vcxproj]"
|
Thanks but this is a duplicate of #2216. I'd rather pass one of the documented arguments than zero. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to #2218, but it looks like it also fixes an issue in the current prebuild for windows.
In the "prebuilds" workflow there is currently an error
Fixes "error C2664: 'HANDLE CreateFileW(LPCWSTR,DWORD,DWORD,LPSECURITY_ATTRIBUTES,DWORD,DWORD,HANDLE)': cannot convert argument 6 from 'nullptr' to 'DWORD' [D:\a\node-canvas\node-canvas\build\canvas.vcxproj]"This change fixes that error.
You can see the build succeeds in my test here https://github.com/acalcutt/node-canvas/actions/runs/4527936648/jobs/7974248529
(note, it still fails to upload since I didn't set that up for my fork)