Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Bluesky to the Social Links menu #2412

Merged
merged 2 commits into from
Nov 20, 2024
Merged

feat: add Bluesky to the Social Links menu #2412

merged 2 commits into from
Nov 20, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds the Bluesky icon to the Social Links menu.

See 1200550061930446-as-1208769260234967

How to test the changes in this Pull Request:

  1. Apply this PR.
  2. Add a link to a Bluesky account to a menu assigned to the Social Links location (or a link including the base URL https://bsky.app/).
  3. Add some more icons to the menu if there aren't any already, to compare the sizes.
  4. View in the header and footer -- confirm that the Bluesky icon appears (a butterfly) and that it appears scaled well with the other icons:

CleanShot 2024-11-19 at 15 10 01

  1. Enable the header solid background, and switch the header to a darker colour, confirm that the butterfly switches to white with the other icons (if you already had a solid background, you need to disable it).

CleanShot 2024-11-19 at 15 09 32

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 19, 2024
@laurelfulford laurelfulford requested a review from a team as a code owner November 19, 2024 23:10
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 20, 2024
@leogermani leogermani merged commit 16a33aa into trunk Nov 20, 2024
5 checks passed
@leogermani leogermani deleted the feat/add-bluesky branch November 20, 2024 12:37
@github-actions GitHub Actions
Copy link

Hey @, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

leogermani pushed a commit that referenced this pull request Nov 21, 2024
@laurelfulford @leogermani
feat: add Bluesky to the Social Links menu (#2412)
e32f604 
* feat: add Bluesky support to the social links menu

* fix: remove inline fill
matticbot pushed a commit that referenced this pull request Nov 21, 2024
@semantic-release-bot
chore(release): 2.3.0-alpha.3 [skip ci]
783a55e 
# [2.3.0-alpha.3](v2.3.0-alpha.2...v2.3.0-alpha.3) (2024-11-21)

### Features

* add Bluesky to the profile fields ([#2413](#2413)) ([a4eb21b](a4eb21b))
* add Bluesky to the Social Links menu ([#2412](#2412)) ([e32f604](e32f604))
matticbot pushed a commit that referenced this pull request Nov 25, 2024
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
86448eb 
# [2.3.0](v2.2.1...v2.3.0) (2024-11-25)

### Bug Fixes

* make button background styles more specific ([#2407](#2407)) ([21f6a4e](21f6a4e))

### Features

* add Bluesky to the profile fields ([#2413](#2413)) ([a4eb21b](a4eb21b))
* add Bluesky to the Social Links menu ([#2412](#2412)) ([e32f604](e32f604))
* **author-archive:** replace twitter icon with x ([2f4709a](2f4709a))
matticbot pushed a commit that referenced this pull request Nov 29, 2024
@semantic-release-bot
chore(release): 2.4.0-alpha.1 [skip ci]
f75ad19 
# [2.4.0-alpha.1](v2.3.0...v2.4.0-alpha.1) (2024-11-29)

### Bug Fixes

* remove translation workaround; the issue is fixed in WP ([#2415](#2415)) ([da4efd9](da4efd9))

### Features

* add Bluesky to the profile fields ([#2413](#2413)) ([6651f67](6651f67))
* add Bluesky to the Social Links menu ([#2412](#2412)) ([16a33aa](16a33aa))
* merge RAS-ACC work into trunk ([#2417](#2417)) ([4488d59](4488d59))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees
No one assigned
Labels
released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @leogermani