-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ras-acc): update Newspack UI variable font sizes for the theme #2296
Conversation
@laurelfulford would you mind re-testing this PR before merging it to make sure I didn't break everything 😅? I've updated the viewport range (782 -> 1280). |
@thomasguillot I retested and everything looks good! Thanks for correcting my breakpoints 😄 And thanks for the initial review, @dkoo! This change seems super low-risk (it doesn't touch anything in the actual theme, it just uses it to override styles in some in-progress work), I'm going to go ahead and merge this into the epic/ras-acc branch! |
🎉 This PR is included in version 1.89.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.91.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.92.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.93.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.1.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.3.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.4.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR updates the Newspack UI font size variable values so the
clamp
sizes are calculated based off of the classic theme's 18px and 20px font sizes. The sizes in the Newspack Plugin are correct for a 16px font size base (which will match our block theme), but the classic theme has font sizes that are slightly larger so it's been messing up the end result.Note: I set the max screen size for the font sizes to 1600px and the min screen size to 600px -- I think this is right based off the sizes coming from Newspack UI, but let me know if it's not!
How to test the changes in this Pull Request:
npm run build
.npm run build
.Other information: