Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for publisher media kit #2317

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This is something I really wanted to avoid but unfortunately the theme doesn't support blockGap which means the Publisher Media Kit page rendered didn't have the correct spacing between patterns.

How to test the changes in this Pull Request:

  1. Switch the Publisher Media Kit plugin to feat: update patterns and remove unused files publisher-media-kit-for-newspack#3
  2. Activate and notice the small gaps (32px)
  3. Switch to this branch
  4. Refresh Media Kit page and now the blocks should have a much bigger gap between them

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Jun 11, 2024
@thomasguillot thomasguillot requested a review from a team as a code owner June 11, 2024 13:39
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jun 25, 2024
@thomasguillot thomasguillot merged commit 4430264 into trunk Jun 26, 2024
5 checks passed
@thomasguillot thomasguillot deleted the add/newspack-publisher-media-kit branch June 26, 2024 08:54
matticbot pushed a commit that referenced this pull request Jul 3, 2024
# [1.91.0-epic-ras-acc.1](v1.90.3...v1.91.0-epic-ras-acc.1) (2024-07-03)

### Features

* add support for publisher media kit ([#2317](#2317)) ([4430264](4430264))
* update clamp calculations based on viewport range of 782 - 1280 ([63307ae](63307ae))
* update Newspack UI variable font sizes for the theme ([212e2fd](212e2fd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.91.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 5, 2024
# [1.91.0-alpha.1](v1.90.3...v1.91.0-alpha.1) (2024-07-05)

### Features

* add support for publisher media kit ([#2317](#2317)) ([4430264](4430264))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.91.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 15, 2024
# [1.91.0](v1.90.5...v1.91.0) (2024-07-15)

### Features

* add support for publisher media kit ([#2317](#2317)) ([4430264](4430264))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.91.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released on @epic/ras-acc released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants