fix(oauth-transients): remove redundant cleanup #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
added
the
[Status] Needs Review
adekbadek
approved these changes
May 14, 2024
github-actions
bot
added
[Status] Approved
fix(oauth): prevent API call if login is abandoned
matticbot
pushed a commit
that referenced
this pull request
May 14, 2024
## [3.8.5](v3.8.4...v3.8.5) (2024-05-14) ### Bug Fixes * **oauth-transients:** remove redundant cleanup ([#3112](#3112)) ([c123c02](c123c02))
|
🎉 This PR is included in version 3.8.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 15, 2024
# [4.0.0-alpha.4](v4.0.0-alpha.3...v4.0.0-alpha.4) (2024-05-15) ### Bug Fixes * autocomplete orders only for virtual products ([#3111](#3111)) ([bfbe554](bfbe554)) * **google-login:** get the email from the /tokeninfo endpoint ([#3117](#3117)) ([3296f1a](3296f1a)) * **google-oauth:** use a custom table for transients ([#3106](#3106)) ([d4a2f5c](d4a2f5c)) * **oauth-transients:** remove redundant cleanup ([#3112](#3112)) ([c123c02](c123c02)) * **ras:** sync purchase data only for most recent order/subscription ([#3086](#3086)) ([2c7763a](2c7763a))
|
🎉 This PR is included in version 4.0.0-alpha.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Removes a redundant cleanup call on
get, and implements a way to let us temporarily disable and reenable cron jobs via an environment constant.How to test the changes in this Pull Request:
wp cron event list, confirm thatnp_oauth_transients_cleanupis scheduled for weekly executiondefine( 'NEWSPACK_CRON_DISABLE', [ 'np_oauth_transients_cleanup' ] );to your wp-config.phpwp cron event list, confirm thatnp_oauth_transients_cleanupis no longer schedulednp_oauth_transients_cleanupfrom theNEWSPACK_CRON_DISABLEarray in wp-config.php and confirm thatnp_oauth_transients_cleanupjob is scheduled againOther information: