Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redesign password authentication flow #2826

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Dec 22, 2023

All Submissions:

Changes proposed in this Pull Request:

Implements the functional changes for the flow redesign without the UI proposed in #2810:

Sign Up

image

Sign In

image

Password

image

How to test the changes in this Pull Request:

Before testing each flow described below, please make sure you have RAS enabled.

Registration

  1. On a fresh session, click to Sign In
  2. Click on "Create an account" and confirm the form changes as represented in the image above
  3. Enter a new email and submit
  4. Confirm you're signed in and redirected to the "My Account" page

OTP authentication

  1. On a fresh session, sign in with the same email used to register
  2. Confirm you're prompted to enter the OTP code sent to your email
  3. Enter the code and confirm you are logged in

Password authentication

  1. Once logged in, click to create a password and go through the password creation flow.
  2. On a fresh session, enter the same email to login
  3. This time, confirm you don't get an OTP and are prompted to enter a password instead
  4. Click "Email me a one-time code instead" and confirm you get an OTP code are able to sign in
  5. Start another fresh session, use the same email
  6. Confirm you are, once again, prompted to enter your password
  7. Enter your password and confirm you are authenticated

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Jan 8, 2024
@miguelpeixe miguelpeixe marked this pull request as ready for review January 8, 2024 19:52
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 8, 2024 19:52
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 8, 2024
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, found one small issue.

@miguelpeixe miguelpeixe requested a review from adekbadek January 10, 2024 16:36
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 12, 2024
@miguelpeixe miguelpeixe merged commit c5190be into epic/ras-acc Jan 12, 2024
7 checks passed
@miguelpeixe miguelpeixe deleted the feat/ras-acc-auth-flow branch January 12, 2024 15:16
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.6.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.9.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @epic/ras-acc [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants