fix: create guest contributors dummy emails

Automattic · Jan 28, 2025 · 969b1a7 · 969b1a7
1 parent 7ef72be
commit 969b1a7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/includes/plugins/co-authors-plus/class-guest-contributor-role.php b/includes/plugins/co-authors-plus/class-guest-contributor-role.php
@@ -268,7 +268,7 @@ public static function get_dummy_email_address( $user_or_name ) {
 		if ( is_string( $user_or_name ) ) {
 			return $user_or_name . '@' . $email_domain;
 		}
-		return $user->user_login . '@' . $email_domain;
+		return $user_or_name->user_login . '@' . $email_domain;
 	}
 
 	/**

diff --git a/tests/unit-tests/guest-contributor-role.php b/tests/unit-tests/guest-contributor-role.php
@@ -19,6 +19,22 @@ public function set_up() { // phpcs:ignore Squiz.Commenting.FunctionComment.Miss
 		wp_reset_postdata();
 	}
 
+	/**
+	 * On a post with author.
+	 */
+	public function test_guest_contributor_role_get_dummy_email() {
+		$email_domain = Guest_Contributor_Role::get_dummy_email_domain();
+		$user = get_userdata( 1 );
+
+		$expected = $user->user_login . '@' . $email_domain;
+
+		$dummy_email = Guest_Contributor_Role::get_dummy_email_address( $user );
+		$this->assertSame( $expected, $dummy_email );
+
+		$dummy_email = Guest_Contributor_Role::get_dummy_email_address( $user->user_login );
+		$this->assertSame( $expected, $dummy_email );
+	}
+
 	/**
 	 * On a post with author.
 	 */