Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update donations patterns and add new one #1731

Merged
merged 4 commits into from
May 19, 2024

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented May 13, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR slightly modifies the Donations patterns that we have:

  • I removed the Group container -- I received feedback from publishers that it's not always easy to move things around when everything is inside a group.
  • Patterns 3 and 4 were extremely similar, so I merged the two into one.
  • I added a new pattern that uses a Cover block, to achieve a similar result as: feat: update donation landing page newspack-plugin#3109
  • I reduced the viewportWidth because I thought it provides a nicer preview now.
  • I changed the Donate block to the Modern style by default

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. In the editor, try to insert a donation pattern
  3. Test 'em all!

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot self-assigned this May 13, 2024
@thomasguillot thomasguillot requested a review from a team as a code owner May 13, 2024 16:06
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thomasguillot thomasguillot merged commit 607c93a into trunk May 19, 2024
7 checks passed
@thomasguillot thomasguillot deleted the update/donation-patterns branch May 19, 2024 13:01
matticbot pushed a commit that referenced this pull request May 20, 2024
# [3.2.0-alpha.1](v3.1.0...v3.2.0-alpha.1) (2024-05-20)

### Bug Fixes

* **donate-block:** fix typo in textdomain and color variables ([#1738](#1738)) ([7f7de88](7f7de88))
* modal checkout continue button ([#1733](#1733)) ([c672d4a](c672d4a))
* respect subscriptions limiter, and handle cart errors in modal ([#1728](#1728)) ([8a828fa](8a828fa))

### Features

* **donate:** add new "Modern" style variation ([#1734](#1734)) ([b83d840](b83d840))
* update donations patterns and add new one ([#1731](#1731)) ([607c93a](607c93a))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-epic-ras-acc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 28, 2024
# [3.2.0](v3.1.0...v3.2.0) (2024-05-28)

### Bug Fixes

* **donate-block:** fix typo in textdomain and color variables ([#1738](#1738)) ([7f7de88](7f7de88))
* modal checkout continue button ([#1733](#1733)) ([c672d4a](c672d4a))
* respect subscriptions limiter, and handle cart errors in modal ([#1728](#1728)) ([8a828fa](8a828fa))

### Features

* **donate:** add new "Modern" style variation ([#1734](#1734)) ([b83d840](b83d840))
* update donations patterns and add new one ([#1731](#1731)) ([607c93a](607c93a))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants