Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: donate block layout for NRH #1682

Merged
merged 10 commits into from
Feb 29, 2024
Merged

fix: donate block layout for NRH #1682

merged 10 commits into from
Feb 29, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 28, 2024

All Submissions:

Changes proposed in this Pull Request:

See Automattic/newspack-plugin#2954

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Feb 28, 2024
@dkoo dkoo changed the base branch from trunk to release February 28, 2024 01:23
@dkoo dkoo marked this pull request as ready for review February 28, 2024 01:23
@dkoo dkoo requested a review from a team as a code owner February 28, 2024 01:23
@dkoo
Copy link
Contributor Author

dkoo commented Feb 29, 2024

With 4e5e38d, redirection to the NRH checkout page is broken. Without 4e5e38d, the Donate blocks throws a fatal error on sites using NRH without Woo active. We need to do more to not execute modal checkout functions and hook callbacks if Woo isn't available. In the meantime, please do not merge this branch until we do that.

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With 4e5e38d, redirection to the NRH checkout page is broken.

Confirmed that this was an error with how the test site was set up, not an error with the NRH redirection -- the site was missing an ID in the NRH settings, but once it was added, redirection behaved as expected.

I added some more verbose feedback on the Newspack Plugin version of this PR, but the short version is I think everything looks good overall! Marking as 'approved'.

@dkoo dkoo merged commit 230889e into release Feb 29, 2024
8 checks passed
@dkoo dkoo deleted the hotfix/nrh-without-woo branch February 29, 2024 18:54
matticbot pushed a commit that referenced this pull request Feb 29, 2024
## [3.0.2](v3.0.1...v3.0.2) (2024-02-29)

### Bug Fixes

* donate block layout for NRH ([#1682](#1682)) ([230889e](230889e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-epic-ras-acc.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants