-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: donate block layout for NRH #1682
Conversation
With 4e5e38d, redirection to the NRH checkout page is broken. Without 4e5e38d, the Donate blocks throws a fatal error on sites using NRH without Woo active. We need to do more to not execute modal checkout functions and hook callbacks if Woo isn't available. In the meantime, please do not merge this branch until we do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 4e5e38d, redirection to the NRH checkout page is broken.
Confirmed that this was an error with how the test site was set up, not an error with the NRH redirection -- the site was missing an ID in the NRH settings, but once it was added, redirection behaved as expected.
I added some more verbose feedback on the Newspack Plugin version of this PR, but the short version is I think everything looks good overall! Marking as 'approved'.
## [3.0.2](v3.0.1...v3.0.2) (2024-02-29) ### Bug Fixes * donate block layout for NRH ([#1682](#1682)) ([230889e](230889e))
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.1.0-epic-ras-acc.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
See Automattic/newspack-plugin#2954
Other information: