Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Cast ObjectId to string inside of MongooseMap. #9938

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Enhancement: Cast ObjectId to string inside of MongooseMap. #9938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
796f9d7
add object id.toString() on methods
jhunterkohler Feb 15, 2021
8d0311e
fix linting errors
jhunterkohler Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/types/map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const Mixed = require('../schema/mixed');
const ObjectId = require('./objectid');
const deepEqual = require('../utils').deepEqual;
const get = require('../helpers/get');
const handleSpreadDoc = require('../helpers/document/handleSpreadDoc');
Expand Down Expand Up @@ -41,6 +42,10 @@ class MongooseMap extends Map {
}

get(key, options) {
if (key instanceof ObjectId) {
key = key.toString();
}

options = options || {};
if (options.getters === false) {
return super.get(key);
Expand All @@ -49,6 +54,10 @@ class MongooseMap extends Map {
}

set(key, value) {
if (key instanceof ObjectId) {
key = key.toString();
}

checkValidKey(key);
value = handleSpreadDoc(value);

Expand Down Expand Up @@ -107,6 +116,10 @@ class MongooseMap extends Map {
}

delete(key) {
if (key instanceof ObjectId) {
key = key.toString();
}

this.set(key, undefined);
super.delete(key);
}
Expand Down