fix(base): allow global option mongoose.set('strictQuery', true); #9016
Conversation
to guard against failed tests not cleaning up after failing which will in turn cause more tests to fail, making it difficult to know the root cause of all the failing tests
| let strictQueryOriginalValue; | ||
|
|
||
| this.beforeEach(() => strictQueryOriginalValue = mongoose.get('strictQuery')); | ||
| this.afterEach(() => mongoose.set('strictQuery', strictQueryOriginalValue)); |
There was a problem hiding this comment.
@vkarpov15 I'd like to know what you think of this approach.
I initially made the cleanup in each test, but if one of those tests had failed, the cleanup wouldn't have happened, causing more tests to fail, making it difficult to find the root cause of all the failing tests.
I think this mitigates this concern, but I still don't like it. How would you do that?
There was a problem hiding this comment.
This approach is ok, but the better approach would be to create a new Mongoose instance using const _mongoose = new mongoose.Mongoose(); and use _mongoose.set(). Check out the test for #6578 for an example.
There was a problem hiding this comment.
Wouldn't this attempt to create a new connection with the same URI for the database? Making tests run significantly slower?
…ror with `ordered: false`, even if only one op failed Re: Automattic#8938
…anchor docs: add anchor tag to strictQuery and strict
fix(documentarray): make sure you can call `unshift()` after `map()`
fixes #6658 for strictQuery