Check if EventEmitter is not null #7346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix for Automattic#7342. Signed-off-by: Milo Casagrande <[email protected]>
|
I tried running the tests locally, but I have 40 failing ones: not sure if this change needs a new test though. The change I did is just mimicking the behaviour for the case where the passed callback is a function. |
vkarpov15
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
Good find! Looks like there were several related issues, all due to the custom update() function. See #7342 (reference) for the issues, they should all be fixed with 5.4.1 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Milo Casagrande [email protected]