Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document not applying manual populate when using a function in schema.options.ref #15138

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Fix document not applying manual populate when using a function in schema.options.ref #15138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0890643
Fix document not applying manual populate when using a function in sc…
IchirokuXVI Dec 30, 2024
305997a
use more consistent check for ref function
vkarpov15 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const documentIsModified = require('./helpers/symbols').documentIsModified;
const documentModifiedPaths = require('./helpers/symbols').documentModifiedPaths;
const documentSchemaSymbol = require('./helpers/symbols').documentSchemaSymbol;
const getSymbol = require('./helpers/symbols').getSymbol;
const modelSymbol = require('./helpers/symbols').modelSymbol;
const populateModelSymbol = require('./helpers/symbols').populateModelSymbol;
const scopeSymbol = require('./helpers/symbols').scopeSymbol;
const schemaMixedSymbol = require('./schema/symbols').schemaMixedSymbol;
Expand Down Expand Up @@ -1386,7 +1387,9 @@ Document.prototype.$set = function $set(path, val, type, options) {
const model = val.constructor;

// Check ref
const ref = schema.options.ref;
const refOpt = typeof schema.options.ref === 'function' && !schema.options.ref[modelSymbol] ? schema.options.ref.call(this, this) : schema.options.ref;

const ref = refOpt?.modelName || refOpt;
if (ref != null && (ref === model.modelName || ref === model.baseModelName)) {
return true;
}
Expand Down
Loading