Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): deduplicate idGetter so creating multiple models with same schema doesn't result in multiple id getters #14492

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(schema): deduplicate idGetter so creating multiple models with same schema doesn't result in multiple id getters #14492

merged 1 commit into from
Apr 4, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14457

Summary

Need to be careful to avoid adding multiple id getters when reusing the same schema multiple times

Examples

@vkarpov15
fix(schema): deduplicate idGetter so creating multiple models with sa…
7e30a08 
…me schema doesn't result in multiple id getters

Fix #14457
@vkarpov15 vkarpov15 added this to the 7.6.11 milestone Apr 2, 2024
@vkarpov15 vkarpov15 merged commit 131d13c into master Apr 4, 2024
38 checks passed
@vkarpov15 vkarpov15 modified the milestones: 7.6.11, 8.2.5 Apr 4, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-14457 branch April 5, 2024 10:36
@vkarpov15 vkarpov15 mentioned this pull request Apr 15, 2024
Closed
2 tasks
@Marion-Rld Marion-Rld mentioned this pull request May 18, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 19, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 19, 2024
Open
@YohanChabiduPerera YohanChabiduPerera mentioned this pull request May 19, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 19, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 20, 2024
Open
@lholmquist lholmquist mentioned this pull request May 20, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request May 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 20, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 21, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 21, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 21, 2024
Open
@shazamakash1 shazamakash1 mentioned this pull request May 22, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request May 22, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request May 22, 2024
Open
@IdrizMirena IdrizMirena mentioned this pull request May 22, 2024
Open
@olexiyb olexiyb mentioned this pull request May 22, 2024
Closed
@nhattpn nhattpn mentioned this pull request May 23, 2024
Closed
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 24, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 24, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 24, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 26, 2024
Open
@boytur boytur mentioned this pull request May 26, 2024
Open
This was referenced May 26, 2024
Open
Open
@akanchhaS akanchhaS mentioned this pull request May 27, 2024
Open
@Safar123 Safar123 mentioned this pull request May 28, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 28, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 28, 2024
Open
@boytur boytur mentioned this pull request May 28, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 28, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 29, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 29, 2024
Open
@nhattpn nhattpn mentioned this pull request May 29, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request May 29, 2024
Open
@lholmquist lholmquist mentioned this pull request May 30, 2024
Closed
@hatifmujahid hatifmujahid mentioned this pull request May 30, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request May 30, 2024
Open
@pasang7 pasang7 mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.3.1
Development

Successfully merging this pull request may close these issues.

getters array in virtualtype for "id" virtual is not deduped
2 participants
@vkarpov15 @hasezoey