[fix] Add back Typescript help for true Mongoose-specific options
for updateOne, updateMany, etc.
#14379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #14378.
MongooseQueryOptions
type was recently edited to include& { [other: string]: any }
in order to support arbitrary options. This implementation broke Typescript support for all of the official Mongoose option properties, in the sense that there's no more auto-completion when you start typing something like "runValidators", and there's no in-line JSDoc displayed.This is caused by the use of the
Omit
Typescript utility in the type foroptions
inupdateOne
,updateMany
, and a few others. Resolution is to redo the implementation with a build-up approach instead of usingOmit
.Examples
See example and screenshots in #14378