Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts/website): fix script to correctly parse "-rc" like versions #14004

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Oct 25, 2023

Summary

This PR fixes the website script to correctly build for rc-like versions by just not reading past the last digit. (also fixed legacy alpha releases)
Also includes some extra fixes:

  • print string that failed to parse
  • trim childprocess output (remove last empty-newline)
  • ignore git tag test

example of a failed run: https://github.com/Automattic/mongoose/actions/runs/6632207139/job/18017384534 (c28cffe)

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Oct 25, 2023
@hasezoey hasezoey requested review from vkarpov15 and Uzlopak October 25, 2023 08:28
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants