Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass correct document type to required and default function #13851

Merged
merged 5 commits into from
Sep 12, 2023
Merged

fix: Pass correct document type to required and default function #13851

merged 5 commits into from
Sep 12, 2023

Conversation

pshaddel
Copy link
Contributor

@pshaddel pshaddel commented Sep 10, 2023 •
edited
Loading

This PR tries to fix #13797.
To fix it, I pass down EnforcedDocType down and assign it to this in the required function.
I have also changed this type of default function in schema, since it had the same issue.

vkarpov15
vkarpov15 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.5.2 milestone Sep 12, 2023
@vkarpov15 vkarpov15 merged commit 71bbf64 into Automattic:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.5.2
Development

Successfully merging this pull request may close these issues.

Typescript: schema type required argument, and this type
2 participants
@pshaddel @vkarpov15