Prevent casting null or undefined UUID field value #13029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `binaryToString` function (line 67), return the _falsy_ (e.g: `null` or `undefined`) value instead of trying to cast it to string. Optional modifications: - in `hex2buffer` function (line 24), check for _falsy_ `hex` before trying to cast it to a `Buffer`. - in `binary2hex` function (line 37), check for _falsy_ `buf` before trying to generate hexadecimal string from it. related to #13025
Freezystem
changed the title
|
Sorry I don't know if written tests are sufficient enough as I can't run them locally because of a Mongo Memory error. |
vkarpov15
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
binaryToStringfunction (line 67), return the falsy (e.g:nullorundefined) value instead of trying to cast it to string.Optional modifications:
hex2bufferfunction (line 24), check for falsyhexbefore trying to cast it to aBuffer.binary2hexfunction (line 37), check for falsybufbefore trying to generate hexadecimal string from it.Examples
related to #13025