feat(mongoose): add setDriver() function to allow overwriting driver in a more consistent way
#11900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er` in a more consistent way
There was a problem hiding this comment.
Can you think of a way we can mimic having different drivers and setting them to verify that this works?
Would deep cloning the driver, modify some arbitrary property, then setting it, and asserting that getting the driver, we'll have the arbitrary property be enough testing?
Otherwise, LGTM.
Uzlopak
reviewed
Jun 7, 2022
Uzlopak
requested changes
Jun 10, 2022
|
|
||
| const openConnection = _mongoose.connections && _mongoose.connections.find(conn => conn.readyState !== STATES.disconnected); | ||
| if (openConnection) { | ||
| const msg = 'Cannot modify Mongoose driver if a connection is already open. ' + |
There was a problem hiding this comment.
nitpick: why do we need a one time variable? We could directly pass it to MongooseError
There was a problem hiding this comment.
Better readability IMO. Easier to break up the long message if there's a temporary variable rather than putting it as a param.
Co-authored-by: Uzlopak <[email protected]>
Co-authored-by: Uzlopak <[email protected]>
…se into vkarpov15/driver-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now overwriting the Mongoose driver is a bit messy, because 1)
ConnectionandCollectionaren't changed when you domongoose.driver.set(), and 2) driver is always global, so no way to have 2 Mongoose instances with the same driver in the same process.Examples
You can now do
mongoose.setDriver()without any extra work to use a different driver.