Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extract and refactor aggregationcursor and querycursor #11488

Merged
merged 5 commits into from
Mar 9, 2022
Merged

chore: extract and refactor aggregationcursor and querycursor #11488

merged 5 commits into from
Mar 9, 2022

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Mar 6, 2022

I unified the typings of aggregationcursor and querycursor to Cursor-type.

Now eachAsync should be more precise, as the DocType is an Array if batchSize is defined. This was not the case previously in AggregationCursor.

vkarpov15
vkarpov15 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.2.5 milestone Mar 9, 2022
@vkarpov15 vkarpov15 merged commit 3441ba0 into Automattic:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @vkarpov15 @subalee