fix(typescript): aggregate.sort() accepts a string but also { field: 'asc'|'ascending'|'desc'|'descending' }
#11479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `Argument of type 'string' is not assignable to parameter of
type 'Record<string, 1 | -1 | { $meta: "textScore"; }>'` when
calling `model.aggregate().sort("-name")`. According to the current
implementation (and per the mongoose docs), `aggregate().sort()`
also accepts a string.
AbdelrahmanHafez
requested changes
Mar 4, 2022
|
Other than the test case, LGTM. |
+1000, I thought there was no test for types (I expected to find them under Since there was no test for |
simonbrunel
changed the title
aggregate.sort() also accepts a string aggregate.sort() also accepts a string but also { field: 'asc'|'ascending'|'desc'|'descending' }
simonbrunel
changed the title
aggregate.sort() also accepts a string but also { field: 'asc'|'ascending'|'desc'|'descending' }aggregate.sort() accepts a string but also { field: 'asc'|'ascending'|'desc'|'descending' }
|
Yeah, it is nice to see the typings tests |
AbdelrahmanHafez
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using TypeScript, calling
model.aggregate().sort("-name")generates the following error:This PR also adds support for mongoose sort keywords:
asc,ascending,descanddescending(according to the current implementation and the mongoose docs).