Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Fix return type of projection method #11176

Merged

Conversation

EugeneKorshenko
Copy link
Contributor

@EugeneKorshenko EugeneKorshenko commented Jan 4, 2022

Summary

Query.projection should return this for correct completion while method chaining.

Introduced here: d7aaa55

@EugeneKorshenko
Copy link
Contributor Author

@vkarpov15 please, take a quick look once you have a chance 🙂

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.1.5 milestone Jan 4, 2022
@vkarpov15 vkarpov15 merged commit 9dcbe71 into Automattic:master Jan 4, 2022
@EugeneKorshenko
Copy link
Contributor Author

@vkarpov15 This PR was a type mistake and misreading of project/projection/select methods. Going to fix this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants