Document.set doesn't work on nested Maps or plain non-strict objects.

[sgpinkus]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Mongoose version

7.0.5

Node.js version

v16.18.1

MongoDB server version

mongo:5.0.9

Typescript version (if applicable)

No response

Description

Deep Document.set using a key with 2 more dots in it like x.set('a.b.c', 1) doesn't seem to work for:

• Map of Maps
• Map of Mixed
• Plain schema object with strict: false.

It should. It does work for just a top level Mixed type.

Steps to Reproduce

const mongoose = require('mongoose');
const { model, Schema } = mongoose;

var TestSchema =  new Schema({
  a: Schema.Types.Mixed,
  b: {
    type: Map,
    of: Schema.Types.Mixed,
    default: {},
  },
  c: {
    type: Map,
    of: {
      type: Map,
      of: Schema.Types.Mixed,
      default: {},
    },
    default: {},
  },
  d: new Schema({
    }, {
      strict: false,
      _id: false,
    },
  )
});

var Test = model('Test', TestSchema);

async function main() {
  await mongoose.connect('mongodb://localhost:27017/test');
  await mongoose.connection.dropDatabase();
  await setThings(); // Only sets a.x.y
}

async function setThings() {
  var x = new Test({});
  x.set('a.x.y', 1);
  x.set('b.x.y', 1);
  x.set('c.x.y', 1);
  x.set('d.x.y', 1);
  await x.save();
  console.log(x.toObject());
}

main()
  .then(() => process.exit())
  .catch((e) => { console.error(e); process.exit(); })

Gives:

{
  b: Map(1) { 'x' => {} },
  c: Map(0) {},
  _id: new ObjectId("644799e0f03d7fd6496855fb"),
  a: { x: { y: 1 } },
  __v: 0
}

Expected Behavior

All the Document.set calls should work.

[vkarpov15]

We fixed one case with #13339, we'll work on the others next week.

[vkarpov15]

Confirmed that #13386 and #13339 are sufficient to make this work, output from OP's script is now:

{
  b: Map(1) { 'x' => { y: 1 } },
  c: Map(1) { 'x' => Map(1) { 'y' => 1 } },
  _id: new ObjectId("646d2c7ba45fbc3e4fe5af82"),
  a: { x: { y: 1 } },
  d: { x: { y: 1 } },
  __v: 0
}