fix(update): dont double-call setters on arrays

Fix #5041
Automattic · Mar 15, 2017 · 0a88085 · 0a88085
1 parent 9105d85
commit 0a88085
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/services/query/castUpdate.js b/lib/services/query/castUpdate.js
@@ -267,6 +267,7 @@ function castUpdateVal(schema, val, op, $conditional) {
     } else {
       val = tmp;
     }
+    return val;
   }
 
   if (op in numberOps) {

diff --git a/test/model.update.test.js b/test/model.update.test.js
@@ -2440,7 +2440,7 @@ describe('model: update:', function() {
 
       var User = db.model('gh5041', UserSchema);
 
-      User.findOneAndUpdate({}, { foos: [ {foo: '13.57'} ] }, function(error) {
+      User.findOneAndUpdate({}, { foos: [{ foo: '13.57' }] }, function(error) {
         assert.ifError(error);
         assert.equal(called, 1);
         done();