Fixed invalid CSS, bumped stylus (take 2) #755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2015 23:59
"highlight-color += 10%" in context-menu.styl produces an invalid color entry in CSS
As described in Automattic#713 - Automattic#713 node generates main.css out of the styles files on demand. This might be convenient for many scenarios, but this is a big security issue because node must have write access to its own code directory -- thus some bug might allow attacker to overwrite ones own code. IMO, Kue should include main.css in the repository, so that a locked-down server without write access wouldn't break it. To regenerate main.css, simply delete it locally and run the code that shows kue site. Once you navigate to it in a browser, the main.css will be regenerated, and can be updated in git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated version of the #712
"highlight-color += 10%" in context-menu.styl produces
an invalid color entry in CSS
Added main.css to avoid requiring write access to the node_modules dir in production