Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to inline very large svgs (~100MB). Cheerio uses
parse5
by default, which is very slow and memory intensive for files of this size. Cheerio also supports (and ships with)htmlparser2
, which has a slightly different API. This PR makes usinghtmlparser2
possible by detecting which API is present.I'm not an expert on this and I'm not sure if the test I wrote is complete enough, but from my tests the only important API difference was that
el.childNodes[0].nodeValue
inparse5
corresponds toel.children[0].data
inhtmlparser2
.