-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External media: Show connection upgrade screen in transition from Photos to Picker #40416
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
ba0e88f
to
9881046
Compare
9881046
to
3f382a9
Compare
The PR has been updated to handle recent changes when the endpoint is unavailable and returns status 404. It is ready for review: @ouikhuan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my latest test, it looks like the COOKIE won't be stored anymore, but if I understand correctly the PR has been rebased and your previous changes should be included, right?
projects/plugins/jetpack/extensions/shared/external-media/sources/google-photos/index.js
Outdated
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/shared/external-media/sources/google-photos/index.js
Outdated
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/shared/external-media/sources/google-photos/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the following scenario and everything works as expected:
- Old connection, with new picker feature on
- Old connection, with picker feature flag off
- New connection with picker feature flag on
- New connection, with picker feature flag off
Great work!
Proposed changes:
GooglePhotosAuthUpgrade
componentGooglePhotosAuth
style, reducing the margin around the paragraphsOther information:
Jetpack product discussion
pdtkmj-36s-p2#comment-5923
Does this pull request change what data or activity we track or use?
Testing instructions:
google-photos-picker
feature