My Jetpack: add connection animation

[IanRamosC]

Proposed changes:

• This PR adds a new animation to the connection step on My Jetpack. This animation is intended to lessen user's confusion while Jetpack is connecting.

Screen.Recording.2024-11-27.at.11.19.52.mov

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pbNhbs-bJV-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

• Spin up a JN site with Jetpack Beta pointing to this feature branch
• Go to My Jetpack
• Click to active your site with one click
• Confirm that the animation looks like the video above and there's no weird behavior

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/connection-animation branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/connection-animation
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[CodeyGuyDylan]

On mobile, the text below the icon could be given some padding or potentially centered (this also happens on mobile when loading recommendations):

The success screen looks good on mobile, it's only like this on the loading screen

I also wonder, with the new animation, do we need this connection success alert above the welcome banner after connection?

This is probably better done in a separate task, but I think we need better error handling when the connection is failed:

Screen.Recording.2024-11-27.at.11.28.44.AM.mov

I don't see any issues with the code, and the only blocking change is the text looking bad on mobile during the loading step, so I'll go ahead and approve this and you can choose whether or not to address the other questions here or not 😄 If not, you probably don't need another review just to check the style change on that text

[grzegorz-cp]

Looks good, and the previous comments were addressed.