Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DIY migration failing to fetch migration key and throwing 403 on page reload #40270

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
+4 −4
Open

Fix DIY migration failing to fetch migration key and throwing 403 on page reload #40270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ffb5e4
Remove check for read flag from migration key get api checks
Imran92 Nov 20, 2024
acd888f
Changelog - Remove read check from migration key access checks
Imran92 Nov 20, 2024
6f236b1
Remove check for read flag from migration key get api checks
Imran92 Nov 20, 2024
64dcd34
Changelog - Remove read check from migration key access checks
Imran92 Nov 20, 2024
189a0e1
Merge branches 'fix/migration-diy-throws-403-on-page-reload' and 'fix…
Imran92 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/jetpack-mu-wpcom/changelog/fix-migration-diy-throws-403-on-page-reload
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fix migration key fetch failing when DIY migration page is reloaded
4 changes: 0 additions & 4 deletions ...s/wpcom-endpoints/class-wpcom-rest-api-v2-endpoint-site-migration-wpcom-migration-key.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ public function can_access() {
return false;
}

if ( 'read' === get_option( $this->key_is_read_option_name, false ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the key_is_read_option_name option is not used anymore. What do you think of cleaning up the related logic (removing the variable and the update_option call)?

return false;
}

return true;
}

Expand Down