Blocks: load later to avoid doing it wrong notices

[jeherve]

Proposed changes:

Let's load our blocks later to avoid any _doing_it_wrong notices introduced in the latest version of WordPress (6.7).

• Related discussion: p1728476310802029-slack-C0299DMPG
• Related ticket: https://core.trac.wordpress.org/ticket/44937
• Counterpart change on WordPress.com: D163434-code

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• Epic: WordPress 6.7 compatibility #38902

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

Note

You'll want to tail your site's error logs while testing this.

• On a free site, connected to WordPress.com, install the WordPress Beta Tester plugin
• Go to Tools > Beta Testing, and set the plugin to use Bleeding edge
• Go to Dashboard > Updates, and update to the most recent version of WP.
• Go to Posts > Add New
• You should see the Jetpack sidebar and Jetpack blocks available in the inserter.
• Upgrade to a Paid plan.
  • You should have access to all blocks, including the paid blocks like Pay with PayPal.
  • None of the above should trigger a notice like this one:

PHP Notice:  Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>jetpack</code> domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the <code>init</code> action or later. Please see <a href="https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 6.7.0.) in /var/www/html/wp-includes/functions.php on line 6099

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/loading-blocks-earlier branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/loading-blocks-earlier
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for November 5, 2024 (scheduled code freeze on November 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[anomiex]

I note the testing instructions are incomplete. You also need to set a non-English (United States) language for your site (and install the corresponding translations).

Works as far as it goes. I'm still seeing the warning, but now it's coming from Automattic\Jetpack\Sync\Actions::init() → ::init_sync_cron_jobs() → ::maybe_schedule_sync_cron() → ::sanitize_filtered_sync_cron_schedule() → wp_get_schedules().

I also note that most of our blocks seem to call register_block_type() from an 'init' hooked function. It's only Contact Info and Tiled Gallery that I found doing it directly on load. So possibly instead of this we could just fix those two blocks.

[coder-karen]

Using the Jetpack Beta plugin for testing the PR, using the bleeding edge version of WordPress, I seem to be getting the notice both before and after applying the branch.

Just saw the previous review coming in so maybe this isn't applicable.

[coder-karen]

I'll close this in favor of #39841 which is a continuation - created a new PR instead of adding to this as the branch name didn't reflect the further changes needed.