Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White-labeled plugin: Add wpcom-migration key endpoint #39377

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Sep 12, 2024

Proposed changes:

  • Add a new endpoint to fetch a site's wpcom migration key from the wpcom-migration plugin. This is modeled after the migrate guru plugin endpoint but uses different classes and a more accurate endpoint name.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply this branch to your AT using Jetpack Beta plugin following instructions in White-labeled plugin: Add wpcom-migration key endpoint #39377 (comment)
  • Apply D161332-code to your sandbox and sandbox public-api.wordpress.com.
  • Apply this branch also on your sandbox by running bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/wpcom-key-endpoint (make sure this PR and D161332-code are running on your sandbox at the same time)
  • Visit the developer console and fetch from /wpcom/v2/sites/%your-AT-site%/atomic-migration-status/wpcom-migration-key
  • You should see a 403 error
  • On the AT site, install and activate the Migrate to WordPress.com plugin (link found in Slack).
  • Fetch the endpoint from the developer console; the migration key field should be populated with the same migration key you'll find at /wp-admin/admin.php?page=wpcom-migration
  • Try to fetch it again and verify that a 403 error is returned

@sixhours sixhours requested a review from a team September 12, 2024 15:04
@sixhours sixhours self-assigned this Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/wpcom-key-endpoint branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/wpcom-key-endpoint
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 12, 2024
@m1r0
Copy link
Member

m1r0 commented Sep 16, 2024

Fetch the endpoint from the developer console; the migration key field should be populated

Unfortunately, I wasn't able to fetch the migration key. I'm stuck on getting 403. Here's what I did, hopefully someone can spot my mistake:

  • Applied the patch and sandboxed public-api.wordpress.com.
  • Applied the branch on the sandbox.
  • Created a WoA site (using the WoA Developer Blog Manager tool).
  • Installed the Jetpack Beta plugin and activated this branch for the jetpack-mu-wpcom-plugin.
  • Added the following to the wp-config.php:
define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
define( 'JETPACK__SANDBOX_DOMAIN', '[my-sandbox-domain]' );

@m1r0
Copy link
Member

m1r0 commented Sep 16, 2024

I've also checked if the wpcom_site_migration_wpcom_migration_key_read option was created in the database, but it wasn't.

@sixhours
Copy link
Contributor Author

@m1r0 That would be user error on my part. I was using the wrong class name for the new plugin so it failed the permissions check. 🙃 That should be resolved with the above updates. Please give it another spin when you get a chance. Thank you!

Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now! 🚀

@sixhours sixhours merged commit 1ce04d7 into trunk Sep 17, 2024
55 checks passed
@sixhours sixhours deleted the add/wpcom-key-endpoint branch September 17, 2024 13:04
sixhours added a commit that referenced this pull request Sep 17, 2024
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 17, 2024
@sixhours sixhours restored the add/wpcom-key-endpoint branch September 17, 2024 14:10
@sixhours sixhours deleted the add/wpcom-key-endpoint branch September 17, 2024 14:22
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* Add new wpcom-migration-key endpoint

* changelog

* Add new endpoint to exception list for phan

* Fix incorrect class name.

* Fix comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants