Update connection ToS messaging

[elliottprogrammer]

Our current ToS message appears in different parts of the plugin and makes it seem like we share data with a third party, which sounds more alarming than it really is.
After collaborating with the legal team (pbNhbs-auw-p2#comment-21945), we agreed on revising and improving the messaging:

• Our current ToS messaging says:

  • "By clicking the [button name] button, you agree to our Terms of Service and to share details with WordPress.com."

• This PR changes the ToS messaging to read:

  • "By clicking [button name], you agree to our Terms of Service and to sync your site’s data with us."

Related to: https://github.com/Automattic/jetpack-roadmap/issues/1554

Proposed changes:

• In the connection ToS message, change "share details with WordPress.com." to "sync your sites data with us."

Other information:

• [#] Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pbNhbs-auw-p2#comment-21945

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Create a Jurassic Ninja site with the Beta Tester plugin running this Jetpack branch: update/improve-tos-message
• In the wp-admin sidebar nav, click "Jetpack".
• Just above the "Set up Jetpack" button, examine the ToS message.
  Verify that it now says:
  • "...and to sync your site's data with us.",
    instead of:
    "...and to share details with WordPress.com."
• Now in the wp-admin sidebar nav, click "My Jetpack"
• Now in the top Welcome banner, click "Finish setting up Jetpack" button.
• Now just above the "Connect your user account" button, examine the ToS message.
  Verify that it now says: "...and to sync your site's data with us.",
• Go ahead and click the "Connect your user account" button. Then click "Approve", and then "Start for free" when presented the pricing page.
• Once connected, Go to "My Jetpack" again, Click the CTA on each of the products
  • Verify that on each of the product card interstitials, there is a ToS that reads, "...and to sync your site's data with us.", instead of, "...and to share details with WordPress.com."
  • On specifically interstitials that are bundled (i.e.- Backup and AntiSpam are bundled with Security), verify that there is now only one(1) combined ToS under both product cards. verify that both product button labels are displayed in the ToS and it reads similar to:, "By clicking Get Jetpack VaultPress Backup or Get Jetpack Security, you agree to our Terms of Service and to sync your site's data with us.", instead of, "...and to share details with WordPress.com."

Test/check the 'Move to WordPress.com' plugin:

• In the Beta Tester plugin, for the "Move to WordPress.com" plugin, click the 'Manage' button and select this feature branch (update/improve-tos-message).
• In the wp-admin sidebar nav, click the "Move to WordPress.com" nav item.
• Now on the "Move to WordPress.com" wp-admin page, you should see the ToS just above the "Get Started" button. Verify the ToS now says, , "...and to sync your site's data with us.", instead of, "...and to share details with WordPress.com."

Test/check the 'Automattic for Agencies client' plugin:

• In the Beta Tester plugin, for the "Automattic for Agencies client" plugin, click the 'Manage' button and select this feature branch (update/improve-tos-message).
• Go to 'Plugins' page, find the "Automattic for Agencies client" plugin item, and click the "Settings" link.
• You should now see the Automattic for Agencies settings page.
• You should see the ToS just above the "Connect this site" button. Verify the ToS now says, , "...and to sync your site's data with us.", instead of, "...and to share details with WordPress.com."

Unit tests:

• Run jetpack test
• For Type of project, select js-packages
• For which project, select connection
• For what tests, select js
• Verify that there are no failing tests.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/improve-tos-message branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/improve-tos-message
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/improve-tos-message
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Migration plugin:

• Next scheduled release: June 4, 2024.
• Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Automattic For agencies client plugin:

• Next scheduled release: June 4, 2024.
• Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[CodeyGuyDylan]

Very comprehensive! I can't find any instances that were missed and it all looks good to me.

I have one blocking request that is we should probably use ‘ instead of ' in the string "sync your site‘s data", I can't find where I saw it (it was a while ago) but I remember Matt talking about how we should be using that instead

[CodeyGuyDylan]

Looks good to me!