Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Google Fonts: Filters out deprecated font provider when reading the theme's theme.json. #35029

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Jan 15, 2024

Related to:

Proposed changes:

This is a continuation to #34306. Here, the deprecated font provider might have been still present in the site's global styles. When a user exported the theme from such sites, the resulting theme.json in the zip file will contain the deprecated font provider. This PR filters out such provider when reading the theme's theme.json as well.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Prepare a WoA site.
  2. Install this theme: test-theme.zip, which contains the deprecated font provider.
  3. Go to the frontend; verify that the text body shows a broken serif font (instead of Jost).
  4. Apply this PR to the site via instructions below provided by the bot.
  5. Go to the frontend again; verify that the text body now correctly uses Jost.

Copy link
Contributor

github-actions bot commented Jan 15, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the google-font-remove-dirty-on-theme-json branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack google-font-remove-dirty-on-theme-json
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Google Fonts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Jan 15, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@fushar fushar force-pushed the google-font-remove-dirty-on-theme-json branch from 734e7ed to c4dd6fd Compare January 16, 2024 04:48
@fushar fushar changed the title Google Fonts: remove dirty data on theme's theme.json as well Jetpack Google Fonts: Filters out deprecated font provider when reading the theme's theme.json. Jan 16, 2024
@fushar fushar marked this pull request as ready for review January 16, 2024 05:03
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

Before After
Screenshot 2024-01-16 at 2 12 55 PM Screenshot 2024-01-16 at 2 44 01 PM

Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected 👍

@fushar fushar merged commit 0e98f91 into trunk Jan 16, 2024
57 of 58 checks passed
@fushar fushar deleted the google-font-remove-dirty-on-theme-json branch January 16, 2024 07:32
@github-actions github-actions bot added this to the jetpack/13.1 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Google Fonts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants