Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Excerpt: render AI excerpt via core slot #33529

Closed
wants to merge 5 commits into from

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Oct 10, 2023

Fixes #36317

Proposed changes:

  • AI Excerpt: render AI excerpt via core slot

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • TBD
Screen.Recording.2023-10-10.at.15.49.11.mov

@retrofox retrofox added [Status] In Progress [Size] L [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Extension] AI Content Lens labels Oct 10, 2023
@retrofox retrofox self-assigned this Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/ai-excerpt-render-via-core-slot branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/ai-excerpt-render-via-core-slot
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on April 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@retrofox
Copy link
Contributor Author

retrofox commented Oct 10, 2023

WordPress/gutenberg#55200 registers the new PluginPostExcerpt slot.

@CGastrell CGastrell removed the [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. label Nov 28, 2023
@lhkowalski
Copy link
Contributor

This needs a rebase and may need some extra work. We are not focusing on this feature for now, so I will move it to To-Do.

@CGastrell CGastrell force-pushed the update/ai-excerpt-render-via-core-slot branch 2 times, most recently from facd12c to cc9db8c Compare February 19, 2024 20:04
@retrofox
Copy link
Contributor Author

The slot has been marked as deprecated. Therefore, we are closing the Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Content Lens [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Size] L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Excerpt: switch to using the PluginPostExcerpt Slot Component
3 participants