-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoPress: dont allow editing video data when doesn't belong to site #30438
VideoPress: dont allow editing video data when doesn't belong to site #30438
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
9ae1e5f
to
774b360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on wpcom, WoA and JN. Working as expected. Nice work!
This PR disables the title and description fields of the Details panel when the video doesn't belong to the site.
Follow-up PR will add a Notice and probably a modal explaining the limitations when creating a block instance by using a video that doesn't belong to the site.
Fixes #
Part of #30417
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Go to the block editor
Create/edit a VideoPress video instance
Set title and description
Confirm it works as expected
Create another VideoPress video block that doesn't belong to the site (https://videopress.com/v/NGYE1Hqy)
Confirm
title
anddescription
fields are disabled.Screen.Recording.2023-05-03.at.16.17.19.mov