Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: check if beta extension is enabled when saving VideoPress video block #29926

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Apr 4, 2023

This PR checks if the beta extension of the "Preview On Hover" feature is enabled when the block saves. If it isn't, the function will return the same makeup generated when the feature is disabled. Otherwise, it will return the new one.

Fixes #

Proposed changes:

  • VideoPress: check if beta extension is enabled when saving VideoPress video block

Other information:

  • Have you written new tests for your changes, if applicable?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Test with an old post with a VideoPress video instance. In case you don't have, you can:
    • Create a JN site
    • Connect the site. Enable the VideoPress module
    • Do not enable beta extension
    • Create a Post
    • Add a VideoPress video block
    • Save the post
  • Test with Jetpack Beta plugin
  • Switch Jetpack plugin with this branch update/videopress-check-beta-extensions-when-saving
  • Go to the testing post
  • Hard-refresh
  • Confirm the block doesn't have validation issues
  • Enable beta exensions
  • Confirm the block doesn't have validation issues
  • Confirm the PreviewOnHover feature is there (block sidebar)

Screen Shot 2023-04-04 at 19 01 45

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/videopress-check-beta-extensions-when-saving

to get started. More details: p9dueE-5Nn-p2

@nunyvega nunyvega force-pushed the update/videopress-check-beta-extensions-when-saving branch from 817349b to e4fc5fd Compare April 5, 2023 08:38
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@retrofox retrofox merged commit 0184dbe into trunk Apr 5, 2023
@retrofox retrofox deleted the update/videopress-check-beta-extensions-when-saving branch April 5, 2023 14:46
@zinigor zinigor added this to the Jetpack/12.1 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants