-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Fetch VideoPress token #29756
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
16360bd
to
0aa60c7
Compare
0aa60c7
to
1c3c594
Compare
1c3c594
to
0760a15
Compare
0760a15
to
01f796c
Compare
01f796c
to
76682ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me! I left one comment, but this is just a question for my own learning. @fluiddot, thank you for all your work on these set of PRs! 👏 👏 🙇♀️
I'd be happy to also approve the gutenberg
and gutenberg-mobile
PRs that this one relies on pending the discussion on the gutenberg
one. 🙇♀️
projects/packages/videopress/src/client/lib/get-media-token/index.native.ts
Show resolved
Hide resolved
# Conflicts: # projects/packages/videopress/src/client/block-editor/blocks/video/edit.native.tsx
@SiobhyB your PR review got dismissed when merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fluiddot, absolutely, re-approved :D
Closes wordpress-mobile/gutenberg-mobile#5512 and closes wordpress-mobile/gutenberg-mobile#5528.
Proposed changes:
getMediaToken
. Part of the functionality of the web version is not implemented, specifically the fetch of the upload token and the persistence of the token.Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
N/A
Testing instructions:
Preparation:
Since the token is fetched via a POST request, we need to use changes from wordpress-mobile/gutenberg-mobile#5596.
{"token": "<TOKEN>"
).