Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Gardening: update triage tasks (wording and Slack notifications) #29706

Merged
merged 8 commits into from
Mar 28, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Mar 24, 2023

Proposed changes:

This PR introduces changes to 2 different triage tasks:

  1. For the task posting on Slack when issues have gathered more than 10 tickets:
  2. For the issue triage:
    • Notify Kitkat of issues that do not have a Priority label yet.
    • For such issues, and until Kitkat intervenes, add a "[Pri] TBD" label. This serves 2 purposes: it helps us detect issues that have triggered a Slack notification so we do not do that multiple times, and it may incite Automatticians to add the missing Priority label on their own.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • p1679680635165249-slack-CQD1HH4MA

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • This is hard to test before merging, so I will be testing in a separate repo.
    • Here is how the new message looks like: p1679912155246299-slack-CN2FSK7L4

jeherve added 5 commits March 24, 2023 19:24
We only want to enable it for the Calypso repo for now, and we'll see the amount of noise this generates.
Once the message has been sent, add a "[Pri] TBD" label to show that priority still needs to be set.

This may have the added advantage of inviting a12s to add a priority themselves.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal labels Mar 24, 2023
@jeherve jeherve self-assigned this Mar 24, 2023
@jeherve jeherve changed the title High volume escalations: notify Kitkat team directly Repo Gardening: update triage tasks (wording and Slack notifications) Mar 24, 2023
@github-actions github-actions bot added [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management labels Mar 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

* @param {string} message - Basic message (without the formatting).
* @returns {object} Object containing the slack message and its formatting.
*/
function formatSlackMessage( payload, channel, message ) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may want to extract this function into a helper that can be shared by the different tasks, since I have a few variations of it already.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Mar 27, 2023
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it

@jeherve jeherve merged commit 60a158b into trunk Mar 28, 2023
@jeherve jeherve deleted the update/repo-gardening-triage-task-messages branch March 28, 2023 15:47
@jeherve jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants