Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum pnpm version #25729

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Update minimum pnpm version #25729

merged 1 commit into from
Aug 19, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Aug 19, 2022

Changes proposed in this Pull Request:

Pnpm v7.9.0 and v7.9.2 each bring some changes to the lockfile. Update
the minimum version accordingly.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Everything should work as before, except for a message to upgrade pnpm if you're on a lower version.

Pnpm v7.9.0 and v7.9.2 each bring some changes to the lockfile. Update
the minimum version accordingly.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Aug 19, 2022
@anomiex anomiex self-assigned this Aug 19, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D86240-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded to 7.9.2, worked as expected.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 19, 2022
@kraftbj kraftbj mentioned this pull request Aug 19, 2022
1 task
@anomiex anomiex merged commit e330776 into trunk Aug 19, 2022
@anomiex anomiex deleted the update/pnpm-version-7.9.2 branch August 19, 2022 18:50
@anomiex
Copy link
Contributor Author

anomiex commented Aug 19, 2022

r250979-wpcom

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 19, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D86240-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your SVN changeset ID (e.g. r12345-wpcom).

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants