Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync class-wpcom-admin-menu.php #25726

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Sync class-wpcom-admin-menu.php #25726

merged 2 commits into from
Aug 19, 2022

Conversation

andres-blanco
Copy link
Contributor

@andres-blanco andres-blanco commented Aug 19, 2022

I've added this changes to this file: wpcom/wp-content/mu-plugins/masterbar/admin-menu/class-wpcom-admin-menu.php on WPCOM and this PR is to get it in Sync.

The changes to the files where done in this 2 diffs: D86138-code D86236-code

Testing instructions:

No visible changes, this changes WPCOM menu.

Does this pull request change what data or activity we track or use?

no

@andres-blanco andres-blanco self-assigned this Aug 19, 2022
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations labels Aug 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 6, 2022.
  • Scheduled code freeze: August 30, 2022.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 19, 2022
@andres-blanco andres-blanco added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Aug 19, 2022
@kraftbj kraftbj enabled auto-merge (squash) August 19, 2022 17:42
@kraftbj kraftbj merged commit 5cac258 into trunk Aug 19, 2022
@kraftbj kraftbj deleted the fix/wpcom-menu branch August 19, 2022 17:42
@github-actions github-actions bot added this to the jetpack/11.3 milestone Aug 19, 2022
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants