Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove claim of support for Node 14 #24678

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Remove claim of support for Node 14 #24678

merged 1 commit into from
Jun 9, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jun 8, 2022

Changes proposed in this Pull Request:

This was added back in #20990 for Gutenberg Mobile. We never really
tested that things still worked in Node 14.

Now Gutenberg Mobile has dropped the need for the monorepo to claim Node
14 support, so let's drop it.

Jetpack product discussion

wordpress-mobile/gutenberg-mobile#4871 (comment)

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Nothing should change here.

@anomiex
Remove claim of support for Node 14
6e5acde 
This was added back in #20990 for Gutenberg Mobile. We never really
tested that things still worked in Node 14.

Now Gutenberg Mobile has dropped the need for the monorepo to claim Node
14 support, so let's drop it.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jun 8, 2022
@anomiex anomiex requested a review from jhnstn June 8, 2022 18:44
@anomiex anomiex requested a review from a team as a code owner June 8, 2022 18:44
@anomiex anomiex self-assigned this Jun 8, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D82244-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Jitm [Package] Lazy Images This package no longer exists in the monorepo. [Package] My Jetpack [Package] Plans [Package] Publicize [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests RNA labels Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: July 5, 2022.
  • Scheduled code freeze: June 28, 2022.

Boost plugin:

  • Next scheduled release: July 5, 2022.
  • Scheduled code freeze: June 27, 2022.

Search plugin:

  • Next scheduled release: July 5, 2022.
  • Scheduled code freeze: June 27, 2022.

Social plugin:

  • Next scheduled release: July 5, 2022.
  • Scheduled code freeze: June 27, 2022.

Starter Plugin plugin:

  • Next scheduled release: July 5, 2022.
  • Scheduled code freeze: June 27, 2022.

Protect plugin:

  • Next scheduled release: July 5, 2022.
  • Scheduled code freeze: June 27, 2022.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 9, 2022
@jeherve jeherve added this to the jetpack/11.1 milestone Jun 9, 2022
@anomiex anomiex merged commit 9dc7c33 into master Jun 9, 2022
@anomiex anomiex deleted the remove/claim-of-support-for-node-14 branch June 9, 2022 15:53
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Great news! One last step: head over to your WordPress.com diff, D82244-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@anomiex
Copy link
Contributor Author

anomiex commented Jun 9, 2022

r247133-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@jhnstn jhnstn Awaiting requested review from jhnstn

Assignees

@anomiex anomiex

Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project [Action] Required Review Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests [JS Package] Analytics [JS Package] API [JS Package] Babel Plugin Replace Textdomain [JS Package] Base Styles [JS Package] Components [JS Package] Config [JS Package] Connection [JS Package] Eslint Changed [JS Package] Eslint Config Target Es [JS Package] I18n Check Webpack Plugin [JS Package] I18n Loader Webpack Plugin [JS Package] IDC [JS Package] Licensing [JS Package] Partner Coupon [JS Package] Publicize Components [JS Package] Remove Asset Webpack Plugin [JS Package] Shared Extension Utils [JS Package] Storybook [JS Package] Webpack Config [Package] Ad aka WordAds [Package] Admin Ui [Package] Assets [Package] Backup [Package] Connection UI This package no longer exists in the monorepo. [Package] Connection [Package] Google Fonts Provider This package no longer exists in the monorepo. [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Jitm [Package] Lazy Images This package no longer exists in the monorepo. [Package] My Jetpack [Package] Plans [Package] Publicize [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Pri] Normal RNA [Tools] Development CLI The tools/cli to assist during JP development. Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
jetpack/11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@anomiex @matticbot @jeherve